[MIRROR] Orbit Poll respects Preferences + Asks for Permission to Unghost #632
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mirrored on Skyrat: Skyrat-SS13/Skyrat-tg#25014
Original PR: tgstation/tgstation#79712
About The Pull Request
Fixes #79676
Ticking either the player or admin "do not consider me for ghost roles" excludes you from the pool of candidates in an orbit ghost poll.
You will now get a
tgui_alert()
asking you if you want to accept being put into the orbit poll role's before you accept it, putting it in line with every other ghost role in the game. If the player doesn't accept, the proc is re-ran with someone else on the list.Why It's Good For The Game
We need both of these behaviors present to keep it standard with what players expect with ghost roles, and it is annoying to be an admin/AFK player who gets hotswapped into one of these roles while they're doing stuff.
Changelog
🆑 san7890
qol: You will no longer be added to the list for ghost-orbit role polls if you have opted out of getting antag ghost roles in your preferences.
qol: You will get a tgui_alert to accept the ghost role if you were selected via the orbit poll, instead of it just throwing you intot he role.
/:cl: